Fix HTML Escape String Comparison in Test supervisor_datatable_spec #… #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireLemons
requested changes
Oct 22, 2021
Comment on lines
45
to
46
| expect(subject[:data].map { |d| Nokogiri::HTML(d[:display_name]).text }).to include(active_supervisor.display_name) | ||
| expect(subject[:data].map { |d| Nokogiri::HTML(d[:display_name]).text }).to include(inactive_supervisor.display_name) |
There was a problem hiding this comment.
Nokogiri::HTML is an alias for Nokogiri::HTML4 I think you want HTML5
There was a problem hiding this comment.
Nokogiri.HTML5 was introduce on version v1.12.0 I believe and casa use "1.11.7"
https://nokogiri.org/rdoc/Nokogiri/HTML5.html
should i update as part of this PR?
There was a problem hiding this comment.
update seems like is not supported by other dependencies
➜ bundle update nokogiri
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies......................
Bundler could not find compatible versions for gem "azure-storage-blob":
In snapshot (Gemfile.lock):
azure-storage-blob (= 2.0.1)
In Gemfile:
azure-storage-blob
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
Bundler could not find compatible versions for gem "nokogiri":
In Gemfile:
nokogiri (>= 1.12.0)
azure-storage-blob was resolved to 2.0.1, which depends on
nokogiri (~> 1.11.0.rc2)
There was a problem hiding this comment.
Maybe just use this instead
There was a problem hiding this comment.
done @FireLemons please review again.
roseliux
force-pushed
the
issue-2810-html-scape-string
branch
from
9c68134
to
a2d0022
Compare
|
could you run |
…ubyforgood#2810 - Add a supervisor with an apostrophe in their name to the list of inactive supervisors before running the test - Use CGI::escapeHTML
roseliux
force-pushed
the
issue-2810-html-scape-string
branch
from
a2d0022
to
919f8db
Compare
FireLemons
approved these changes
Oct 23, 2021
|
🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…2810
What github issue is this PR for, if any?
Resolves #2810
What changed, and why?
Add a supervisor with an apostrophe in their name to the list of inactive supervisors before running the test.